fix(desktop): suppress console window flashes from background spawns on Windows#2493
Open
adamentwistle wants to merge 1 commit into
Open
fix(desktop): suppress console window flashes from background spawns on Windows#2493adamentwistle wants to merge 1 commit into
adamentwistle wants to merge 1 commit into
Conversation
…on Windows On Windows, every std::process::Command spawn of a console-subsystem binary (git, node, ffmpeg, agent CLIs) opens a visible console window unless CREATE_NO_WINDOW is set. The desktop app spawns these in the background constantly — git exec, agent runtime readiness/version probes, auth status probes, ffmpeg transcodes, provider invocations — so windows flash over the UI throughout normal use. Set the CREATE_NO_WINDOW creation flag (0x08000000) on all background spawn sites under desktop/src-tauri. Guarded by #[cfg(windows)]; no behavior change on other platforms. Interactive/foreground spawns are untouched. Signed-off-by: Adam <adam@optaimi.com>
adamentwistle
force-pushed
the
windows-no-console-flash
branch
from
July 23, 2026 09:38
5cefc50 to
08bb5a8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2490
On Windows, every
std::process::Commandspawn of a console-subsystem binary(git, node, ffmpeg, agent CLIs) opens a visible console window unless the
CREATE_NO_WINDOWprocess-creation flag is set. The desktop app spawns thesein the background constantly — git exec, agent runtime readiness/version
probes, auth status probes, ffmpeg transcodes, provider invocations — so black
console windows flash over the UI throughout normal use.
Change
Set the
CREATE_NO_WINDOWcreation flag (0x0800_0000) on all backgroundspawn sites under
desktop/src-tauri, guarded by#[cfg(windows)]viastd::os::windows::process::CommandExt:commands/project_git_exec.rs—run_gitcommands/agent_discovery/managed_node.rs— managed node--versionprobecommands/agent_model_process.rs— agent models listingcommands/agent_auth.rs— ACP auth command + Claude subscription logincommands/media_transcode.rs— ffmpeg command builder + test fixture generationcommands/relay_reconnect.rs—run_with_timeoutmanaged_agents/backend.rs—invoke_providermanaged_agents/discovery.rs— login-shell probe, auth status probe, codex ACP version probemanaged_agents/agent_env.rs— env probe testsNo new dependencies. No behavior change on non-Windows platforms (the flag is
compiled out). Interactive/foreground spawns are untouched.
Testing
cargo checkpasses on Windows (MSVC, Rust 1.95.0) with no new warnings vs aclean-upstream baseline.
the constant console-window flashes are gone; git operations, agent
discovery, auth probes, and transcodes all still work.